Commit 851f8a69 authored Jul 30, 2006 by Venkat Yekkirala Committed by Linus Torvalds Jul 31, 2006

[PATCH] selinux: fix bug in security_compute_sid



Initializes newcontext sooner to allow for its destruction in all cases.

Signed-off-by: Venkat Yekkirala <vyekkirala@TrustedCS.com>
Signed-off-by: Stephen Smalley <sds@tycho.nsa.gov>
Acked-by: James Morris <jmorris@namei.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent ddccef3b

security/selinux/ss/services.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -833,6 +833,8 @@ static int security_compute_sid(u32 ssid,
		goto out;
		}

		context_init(&newcontext);

		POLICY_RDLOCK;

		scontext = sidtab_search(&sidtab, ssid);
		@@ -850,8 +852,6 @@ static int security_compute_sid(u32 ssid,
		goto out_unlock;
		}

		context_init(&newcontext);

		/* Set the user identity. */
		switch (specified) {
		case AVTAB_TRANSITION: