Commit 84f6942c authored Mar 07, 2013 by Jingoo Han Committed by Bryan Wu Apr 01, 2013

leds: leds-lt3593: set devm_gpio_request_one() flags param correctly



The devm_gpio_request_one() flags parameter was set to:

  GPIOF_DIR_OUT | state

GPIOF_DIR_OUT and GPIOF_DIR_IN are defined as below:

  GPIOF_DIR_OUT   (0 << 0)
  GPIOF_DIR_IN    (1 << 0)

So, when 'state' is 1, the gpio pin can be set as input, instead
of output.

To prevent this problem, GPIOF_OUT_INIT flags should be used when
using devm_gpio_request_one().

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Bryan Wu <cooloney@gmail.com>

parent e9dd68cf

drivers/leds/leds-lt3593.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -106,8 +106,9 @@ static int create_lt3593_led(const struct gpio_led *template,
		if (!template->retain_state_suspended)
		led_dat->cdev.flags \|= LED_CORE_SUSPENDRESUME;

		ret = devm_gpio_request_one(parent, template->gpio,
		GPIOF_DIR_OUT \| state, template->name);
		ret = devm_gpio_request_one(parent, template->gpio, state ?
		GPIOF_OUT_INIT_HIGH : GPIOF_OUT_INIT_LOW,
		template->name);
		if (ret < 0)
		return ret;