Commit 84aa6687 authored May 03, 2016 by Kangjie Lu Committed by Sasha Levin Jul 12, 2016

net: fix infoleak in llc



[ Upstream commit b8670c09f37bdf2847cc44f36511a53afc6161fd ]

The stack object “info” has a total size of 12 bytes. Its last byte
is padding which is not initialized and leaked via “put_cmsg”.

Signed-off-by: Kangjie Lu <kjlu@gatech.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>

parent 361d2edc

net/llc/af_llc.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -626,6 +626,7 @@ static void llc_cmsg_rcv(struct msghdr msg, struct sk_buff skb)
		if (llc->cmsg_flags & LLC_CMSG_PKTINFO) {
		struct llc_pktinfo info;

		memset(&info, 0, sizeof(info));
		info.lpi_ifindex = llc_sk(skb->sk)->dev->ifindex;
		llc_pdu_decode_dsap(skb, &info.lpi_sap);
		llc_pdu_decode_da(skb, info.lpi_mac);