Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 84107ed7 authored by Nicholas Mc Guire's avatar Nicholas Mc Guire Committed by Sasha Levin
Browse files

[media] gscpa_m5602: use msecs_to_jiffies for conversions 



[ Upstream commit 63f2f417526fc54191f2b813f72dc1d5322bede8 ]

API compliance scanning with coccinelle flagged:
./drivers/media/usb/gspca/m5602/m5602_s5k83a.c:180:9-25:
	 WARNING: timeout (100) seems HZ dependent

Numeric constants passed to schedule_timeout() make the effective
timeout HZ dependent which makes little sense in a polling loop for
the cameras rotation state.
Fixed up by converting the constant to jiffies with msecs_to_jiffies()

Signed-off-by: default avatarNicholas Mc Guire <hofrat@osadl.org>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
Signed-off-by: default avatarSasha Levin <sasha.levin@oracle.com>
parent 7a278b4c

drivers/media/usb/gspca/m5602/m5602_s5k83a.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -177,7 +177,7 @@ static int rotation_thread_function(void *data) 
	__s32 vflip, hflip;

	__s32 vflip, hflip;





	set_current_state(TASK_INTERRUPTIBLE);

	set_current_state(TASK_INTERRUPTIBLE);

	while (!schedule_timeout(100)) {

	while (!schedule_timeout(msecs_to_jiffies(100))) {

		if (mutex_lock_interruptible(&sd->gspca_dev.usb_lock))

		if (mutex_lock_interruptible(&sd->gspca_dev.usb_lock))

			break;

			break;