Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 84005eb5 authored by Thierry Reding's avatar Thierry Reding Committed by Dmitry Torokhov
Browse files

Input: tsc2007 - add max_rt parameter to platform data 



Finger touch events or very quick stylus events on low-quality panels
can cause the tsc2007 to read bogus values. Looking at oscilloscope
snapshots, this seems to be caused by the touch event disappearing
during the measurements. These bogus values result in misclicks, where
the X and Y values deviate from the real position.

Most of these misclicks can be filtered out by setting a low enough
threshold for the maximum resistance (which is loosely the inverse of
the pressure) allowed to consider a set of values valid. Since this
behaviour is largely dependent on the type and quality of the panel,
this commit introduces the max_rt parameter. The default value is kept
at MAX_12BIT.

Signed-off-by: default avatarThierry Reding <thierry.reding@avionic-design.de>
Signed-off-by: default avatarDmitry Torokhov <dtor@mail.ru>
parent 4a1a42af

drivers/input/touchscreen/tsc2007.c

+3 −1
Original line number Diff line number Diff line
@@ -75,6 +75,7 @@ struct tsc2007 { 


	u16			model;

	u16			x_plate_ohms;

	u16			max_rt;



	bool			pendown;

	int			irq;
@@ -185,7 +186,7 @@ static void tsc2007_work(struct work_struct *work) 
	tsc2007_read_values(ts, &tc);



	rt = tsc2007_calculate_pressure(ts, &tc);

	if (rt > MAX_12BIT) {

	if (rt > ts->max_rt) {

		/*

		 * Sample found inconsistent by debouncing or pressure is

		 * beyond the maximum. Don't report it to user space,
@@ -294,6 +295,7 @@ static int __devinit tsc2007_probe(struct i2c_client *client, 


	ts->model             = pdata->model;

	ts->x_plate_ohms      = pdata->x_plate_ohms;

	ts->max_rt            = pdata->max_rt ? : MAX_12BIT;

	ts->get_pendown_state = pdata->get_pendown_state;

	ts->clear_penirq      = pdata->clear_penirq;

include/linux/i2c/tsc2007.h

+1 −0
Original line number Diff line number Diff line
@@ -6,6 +6,7 @@ 
struct tsc2007_platform_data {

	u16	model;				/* 2007. */

	u16	x_plate_ohms;

	u16	max_rt; /* max. resistance above which samples are ignored */



	int	(*get_pendown_state)(void);

	void	(*clear_penirq)(void);		/* If needed, clear 2nd level