Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 83a9ba00 authored by Eric Sandeen's avatar Eric Sandeen Committed by Ben Myers
Browse files

xfs: don't zero structure members after a memset(0) 



Commit 408cc4e9
added memset(0, ...) to allocation args structures,
so there is no need to explicitly set any of the fields
to 0 after that.

Signed-off-by: default avatarEric Sandeen <sandeen@redhat.com>
Reviewed-by: default avatarMark Tinguely <tinguely@sgi.com>
Signed-off-by: default avatarBen Myers <bpm@sgi.com>
parent f7555032

fs/xfs/xfs_alloc.c

+0 −2
Original line number Diff line number Diff line
@@ -1925,8 +1925,6 @@ xfs_alloc_fix_freelist( 
	targs.mp = mp;

	targs.agbp = agbp;

	targs.agno = args->agno;

	targs.mod = targs.minleft = targs.wasdel = targs.userdata =

		targs.minalignslop = 0;

	targs.alignment = targs.minlen = targs.prod = targs.isfl = 1;

	targs.type = XFS_ALLOCTYPE_THIS_AG;

	targs.pag = pag;

fs/xfs/xfs_bmap.c

+0 −4
Original line number Diff line number Diff line
@@ -3099,8 +3099,6 @@ xfs_bmap_extents_to_btree( 
		args.fsbno = *firstblock;

	}

	args.minlen = args.maxlen = args.prod = 1;

	args.total = args.minleft = args.alignment = args.mod = args.isfl =

		args.minalignslop = 0;

	args.wasdel = wasdel;

	*logflagsp = 0;

	if ((error = xfs_alloc_vextent(&args))) {
@@ -3259,8 +3257,6 @@ xfs_bmap_local_to_extents( 
			args.type = XFS_ALLOCTYPE_NEAR_BNO;

		}

		args.total = total;

		args.mod = args.minleft = args.alignment = args.wasdel =

			args.isfl = args.minalignslop = 0;

		args.minlen = args.maxlen = args.prod = 1;

		if ((error = xfs_alloc_vextent(&args)))

			goto done;

fs/xfs/xfs_ialloc.c

+0 −4
Original line number Diff line number Diff line
@@ -279,8 +279,6 @@ xfs_ialloc_ag_alloc( 
		  (args.agbno < be32_to_cpu(agi->agi_length)))) {

		args.fsbno = XFS_AGB_TO_FSB(args.mp, agno, args.agbno);

		args.type = XFS_ALLOCTYPE_THIS_BNO;

		args.mod = args.total = args.wasdel = args.isfl =

			args.userdata = args.minalignslop = 0;

		args.prod = 1;



		/*
@@ -333,8 +331,6 @@ xfs_ialloc_ag_alloc( 
		 * Allocate a fixed-size extent of inodes.

		 */

		args.type = XFS_ALLOCTYPE_NEAR_BNO;

		args.mod = args.total = args.wasdel = args.isfl =

			args.userdata = args.minalignslop = 0;

		args.prod = 1;

		/*

		 * Allow space for the inode btree to split.