Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 829d3fba authored by Vignesh Radhakrishnan's avatar Vignesh Radhakrishnan Committed by Prasad Sodagudi
Browse files

smpboot: use kmemleak_not_leak for smpboot_thread_data 



Kmemleak reports the following memory leak :

    [<ffffffc0002faef8>] create_object+0x140/0x274
    [<ffffffc000cc3598>] kmemleak_alloc+0x80/0xbc
    [<ffffffc0002f707c>] kmem_cache_alloc_trace+0x148/0x1d8
    [<ffffffc00024504c>] __smpboot_create_thread.part.2+0x2c/0xec
    [<ffffffc0002452b4>] smpboot_register_percpu_thread+0x90/0x118
    [<ffffffc0016067c0>] spawn_ksoftirqd+0x1c/0x30
    [<ffffffc000200824>] do_one_initcall+0xb0/0x14c
    [<ffffffc001600820>] kernel_init_freeable+0x84/0x1e0
    [<ffffffc000cc273c>] kernel_init+0x10/0xcc
    [<ffffffc000203bbc>] ret_from_fork+0xc/0x50

This memory allocated here points to smpboot_thread_data.
Data is used as an argument for this kthread.

This will be used when smpboot_thread_fn runs. Therefore,
is not a leak.

Call kmemleak_not_leak for smpboot_thread_data pointer
to ensure that kmemleak doesn't report it as a memory
leak.

Change-Id: I02b0a7debea3907b606856e069d63d7991b67cd9
Signed-off-by: default avatarVignesh Radhakrishnan <vigneshr@codeaurora.org>
Signed-off-by: default avatarPrasad Sodagudi <psodagud@codeaurora.org>
parent 77813844

kernel/smpboot.c

+3 −0
Original line number Diff line number Diff line
@@ -12,6 +12,7 @@ 
#include <linux/percpu.h>

#include <linux/kthread.h>

#include <linux/smpboot.h>

#include <linux/kmemleak.h>



#include "smpboot.h"
@@ -174,6 +175,8 @@ __smpboot_create_thread(struct smp_hotplug_thread *ht, unsigned int cpu) 
	td = kzalloc_node(sizeof(*td), GFP_KERNEL, cpu_to_node(cpu));

	if (!td)

		return -ENOMEM;



	kmemleak_not_leak(td);

	td->cpu = cpu;

	td->ht = ht;