Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 821e67a1 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

Staging: comedi: fix read past end of array in cb_pcidda_attach() 



There are only 6 elements in the cb_pcidda_boards[] array so the
original code read past the end.  After this change nothing uses N_BOARDS
so I removed the definition.

Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 15d93ed0

drivers/staging/comedi/drivers/cb_pcidda.c

+1 −2
Original line number Diff line number Diff line
@@ -52,7 +52,6 @@ Please report success/failure with other different cards to 
#include "8255.h"



#define PCI_VENDOR_ID_CB	0x1307	/*  PCI vendor number of ComputerBoards */

#define N_BOARDS	10	/*  Number of boards in cb_pcidda_boards */

#define EEPROM_SIZE	128	/*  number of entries in eeprom */

#define MAX_AO_CHANNELS 8	/*  maximum number of ao channels for supported boards */
@@ -307,7 +306,7 @@ static int cb_pcidda_attach(struct comedi_device *dev, 
					continue;

				}

			}

			for (index = 0; index < N_BOARDS; index++) {

			for (index = 0; index < ARRAY_SIZE(cb_pcidda_boards); index++) {

				if (cb_pcidda_boards[index].device_id ==

				    pcidev->device) {

					goto found;