Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 814a18a5 authored by Paul Walmsley's avatar Paul Walmsley
Browse files

ARM: OMAP AM3517/05: hwmod data: block WFI when EMAC active 

According to Mark Greer, on OMAP AM3517/3505 chips, the EMAC is unable
to wake the ARM up from WFI:

    http://www.spinics.net/lists/arm-kernel/msg174734.html



Further troubleshooting was unable to narrow the problem down.  So we
don't have much choice other than to block WFI when the EMAC is active
with the HWMOD_BLOCK_WFI flag.

Based on Mark's original patch.  We're removing the omap_device-based
pm_lats code, so a different approach was needed.

This third version contains some corrections thanks to Mark's review.

Signed-off-by: default avatarPaul Walmsley <paul@pwsan.com>
Cc: Mark A. Greer <mgreer@animalcreek.com>
Acked-by: default avatarMark A. Greer <mgreer@animalcreek.com>
parent 1e3d8fe7

arch/arm/mach-omap2/omap_hwmod_3xxx_data.c

+6 −1
Original line number Diff line number Diff line
@@ -3493,7 +3493,12 @@ static struct omap_hwmod am35xx_emac_hwmod = { 
	.name		= "davinci_emac",

	.mpu_irqs	= am35xx_emac_mpu_irqs,

	.class		= &am35xx_emac_class,

	.flags		= HWMOD_NO_IDLEST,

	/*

	 * According to Mark Greer, the MPU will not return from WFI

	 * when the EMAC signals an interrupt.

	 * http://www.spinics.net/lists/arm-kernel/msg174734.html

	 */

	.flags		= (HWMOD_NO_IDLEST | HWMOD_BLOCK_WFI),

};



/* l3_core -> davinci emac interface */