Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 812c083e authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Mauro Carvalho Chehab
Browse files

[media] radio-shark: Mark shark_resume_leds() inline to kill compiler warning 



If SHARK_USE_LEDS=1, but CONFIG_PM=n:
drivers/media/radio/radio-shark.c:275: warning: ‘shark_resume_leds’ defined but not used
Instead of making the #ifdef logic even more complicated (there are already
two definitions of shark_resume_leds()), mark shark_resume_leds() inline to
kill the compiler warning. shark_resume_leds() is small and it has only one
caller.

Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
parent 3189ef02

drivers/media/radio/radio-shark.c

+1 −3
Original line number Diff line number Diff line
@@ -271,8 +271,7 @@ static void shark_unregister_leds(struct shark_device *shark) 
	cancel_work_sync(&shark->led_work);

}



#ifdef CONFIG_PM

static void shark_resume_leds(struct shark_device *shark)

static inline void shark_resume_leds(struct shark_device *shark)

{

	if (test_bit(BLUE_IS_PULSE, &shark->brightness_new))

		set_bit(BLUE_PULSE_LED, &shark->brightness_new);
@@ -281,7 +280,6 @@ static void shark_resume_leds(struct shark_device *shark) 
	set_bit(RED_LED, &shark->brightness_new);

	schedule_work(&shark->led_work);

}

#endif

#else

static int shark_register_leds(struct shark_device *shark, struct device *dev)

{