Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 80bd2b81 authored by Ghanim Fodi's avatar Ghanim Fodi
Browse files

msm: ipa3: Check input parameter before de-referencing it 



At ipa3_usb_xdci_connect() we de-reference an input pointer
before validating it. This code switches the order.

Change-Id: I712c74c976c848c350cac9fe630120c48361720d
Signed-off-by: default avatarGhanim Fodi <gfodi@codeaurora.org>
parent 5ef36a5b

drivers/platform/msm/ipa/ipa_v3/ipa_usb.c

+4 −4
Original line number Diff line number Diff line
@@ -1440,7 +1440,7 @@ static int ipa3_usb_xdci_connect_internal( 
	int result = -EFAULT;

	struct ipa_rm_perf_profile profile;



	IPA_USB_DBG("ipa3_usb_xdci_connect: entry\n");

	IPA_USB_DBG("ipa3_usb_xdci_connect_internal: entry\n");

	if (params == NULL || !ipa3_usb_check_connect_params(params)) {

		IPA_USB_ERR("bad parameters.\n");

		return -EINVAL;
@@ -1544,10 +1544,10 @@ int ipa3_usb_xdci_connect(struct ipa_usb_xdci_chan_params *ul_chan_params, 


	mutex_lock(&ipa3_usb_ctx->general_mutex);

	IPA_USB_DBG("ipa3_usb_xdci_connect: entry\n");

	if (dl_chan_params == NULL || dl_out_params == NULL ||

	if (connect_params == NULL || dl_chan_params == NULL ||

		dl_out_params == NULL ||

		(connect_params->teth_prot != IPA_USB_DIAG &&

		(ul_chan_params == NULL || ul_out_params == NULL)) ||

		connect_params == NULL) {

		(ul_chan_params == NULL || ul_out_params == NULL))) {

		IPA_USB_ERR("bad parameters.\n");

		result = -EINVAL;

		goto bad_params;