Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8082c37c authored Mar 04, 2008 by YOSHIFUJI Hideaki

[NET] NEIGHBOUR: Remove unpopular neigh_is_connected().



neigh_is_connected() is not popular at all, and the only user
drivers/net/cxgb3/l2t.c:t3_l2t_update() also have raw (expanded) expression.
Let's expand it and remove the inline function.

Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>

parent 0e7b8dcd

drivers/net/cxgb3/l2t.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -407,7 +407,7 @@ found:
		} else if (neigh->nud_state & (NUD_CONNECTED\|NUD_STALE))
		setup_l2e_send_pending(dev, NULL, e);
		} else {
		e->state = neigh_is_connected(neigh) ?
		e->state = neigh->nud_state & NUD_CONNECTED ?
		L2T_STATE_VALID : L2T_STATE_STALE;
		if (memcmp(e->dmac, neigh->ha, 6))
		setup_l2e_send_pending(dev, NULL, e);

include/net/neighbour.h

+0 −6

Original line number	Diff line number	Diff line
		@@ -284,12 +284,6 @@ static inline void neigh_confirm(struct neighbour *neigh)
		neigh->confirmed = jiffies;
		}

		static inline int neigh_is_connected(struct neighbour *neigh)
		{
		return neigh->nud_state&NUD_CONNECTED;
		}


		static inline int neigh_event_send(struct neighbour neigh, struct sk_buff skb)
		{
		neigh->used = jiffies;