Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 80032cff authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

rtnetlink: potential ERR_PTR dereference 



In the original code, if rtnl_create_link() returned an ERR_PTR then that
would get passed to rtnl_configure_link() which dereferences it.

Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Acked-by: default avatarPatrick McHardy <kaber@trash.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f4f914b5

net/core/rtnetlink.c

+3 −2
Original line number Diff line number Diff line
@@ -1270,10 +1270,11 @@ replay: 
			err = ops->newlink(net, dev, tb, data);

		else

			err = register_netdevice(dev);

		if (err < 0 && !IS_ERR(dev)) {



		if (err < 0 && !IS_ERR(dev))

			free_netdev(dev);

		if (err < 0)

			goto out;

		}



		err = rtnl_configure_link(dev, ifm);

		if (err < 0)