Commit 7e4ac934 authored Jul 21, 2015 by Zhuang Jin Can Committed by Sasha Levin Aug 27, 2015

xhci: do not report PLC when link is in internal resume state



[ Upstream commit aca3a0489ac019b58cf32794d5362bb284cb9b94 ]

Port link change with port in resume state should not be
reported to usbcore, as this is an internal state to be
handled by xhci driver. Reporting PLC to usbcore may
cause usbcore clearing PLC first and port change event irq
won't be generated.

Cc: <stable@vger.kernel.org>
Signed-off-by: Zhuang Jin Can <jin.can.zhuang@intel.com>
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>

parent 76840406

drivers/usb/host/xhci-hub.c

+8 −1

Original line number	Diff line number	Diff line
		@@ -591,7 +591,14 @@ static u32 xhci_get_port_status(struct usb_hcd *hcd,
		status \|= USB_PORT_STAT_C_RESET << 16;
		/* USB3.0 only */
		if (hcd->speed == HCD_USB3) {
		if ((raw_port_status & PORT_PLC))
		/* Port link change with port in resume state should not be
		* reported to usbcore, as this is an internal state to be
		* handled by xhci driver. Reporting PLC to usbcore may
		* cause usbcore clearing PLC first and port change event
		* irq won't be generated.
		*/
		if ((raw_port_status & PORT_PLC) &&
		(raw_port_status & PORT_PLS_MASK) != XDEV_RESUME)
		status \|= USB_PORT_STAT_C_LINK_STATE << 16;
		if ((raw_port_status & PORT_WRC))
		status \|= USB_PORT_STAT_C_BH_RESET << 16;