Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7e41f9bc authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

USB: sierra: fix memory leak in attach error path 



Make sure port private data is deallocated on errors in attach.

Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarJohan Hovold <jhovold@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b8f0e820

drivers/usb/serial/sierra.c

+8 −1
Original line number Diff line number Diff line
@@ -905,7 +905,7 @@ static int sierra_startup(struct usb_serial *serial) 
			dev_dbg(&port->dev, "%s: kmalloc for "

				"sierra_port_private (%d) failed!\n",

				__func__, i);

			return -ENOMEM;

			goto err;

		}

		spin_lock_init(&portdata->lock);

		init_usb_anchor(&portdata->active);
@@ -942,6 +942,13 @@ static int sierra_startup(struct usb_serial *serial) 
	}



	return 0;

err:

	for (--i; i >= 0; --i) {

		portdata = usb_get_serial_port_data(serial->port[i]);

		kfree(portdata);

	}



	return -ENOMEM;

}



static void sierra_release(struct usb_serial *serial)