Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7e3e5d09 authored by Allan Stephens's avatar Allan Stephens Committed by David S. Miller
Browse files

tipc: Prevent crash when broadcast link cannot send to all nodes 



Allow TIPC's broadcast link to continue operation when it is unable
to send a message to all nodes in the cluster.  Previously, the
broadcast link attempted to put the broadcast pseudo-bearer into a
blocked state; however, this caused a crash because the associated
bearer structure is only partially initialized.  Further
investigation has revealed some conceptual problems with blocking
the pseudo-bearer; consequently, this functionality has been
disabled for the time being and the undelivered message is
eventually resent by the broadcast link's existing message
retransmission mechanism (if possible).

Signed-off-by: default avatarAllan Stephens <allan.stephens@windriver.com>
Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b02b69c8

net/tipc/bcast.c

+6 −4
Original line number Diff line number Diff line
@@ -609,11 +609,13 @@ static int tipc_bcbearer_send(struct sk_buff *buf, 
		bcbearer->remains = bcbearer->remains_new;

	}



	/* Unable to reach all targets */

	/*

	 * Unable to reach all targets (indicate success, since currently

	 * there isn't code in place to properly block & unblock the

	 * pseudo-bearer used by the broadcast link)

	 */



	bcbearer->bearer.publ.blocked = 1;

	bcl->stats.bearer_congs++;

	return 1;

	return TIPC_OK;

}



/**