Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7e2dcc69 authored by Axel Lin's avatar Axel Lin Committed by Jonathan Cameron
Browse files

iio: dac: ad5791: Don't set error code to [pos|neg]_voltage_uv 



regulator_get_voltage() may return negative error code.
Don't set error code to to pos_voltage_uv and neg_voltage_uv.

Signed-off-by: default avatarAxel Lin <axel.lin@ingics.com>
Acked-by: default avatarLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
parent 272cc9c8

drivers/iio/dac/ad5791.c

+11 −2
Original line number Diff line number Diff line
@@ -365,7 +365,11 @@ static int __devinit ad5791_probe(struct spi_device *spi) 
		if (ret)

			goto error_put_reg_pos;



		pos_voltage_uv = regulator_get_voltage(st->reg_vdd);

		ret = regulator_get_voltage(st->reg_vdd);

		if (ret < 0)

			goto error_disable_reg_pos;



		pos_voltage_uv = ret;

	}



	st->reg_vss = regulator_get(&spi->dev, "vss");
@@ -374,7 +378,11 @@ static int __devinit ad5791_probe(struct spi_device *spi) 
		if (ret)

			goto error_put_reg_neg;



		neg_voltage_uv = regulator_get_voltage(st->reg_vss);

		ret = regulator_get_voltage(st->reg_vss);

		if (ret < 0)

			goto error_disable_reg_neg;



		neg_voltage_uv = ret;

	}



	st->pwr_down = true;
@@ -428,6 +436,7 @@ error_put_reg_neg: 
	if (!IS_ERR(st->reg_vss))

		regulator_put(st->reg_vss);



error_disable_reg_pos:

	if (!IS_ERR(st->reg_vdd))

		regulator_disable(st->reg_vdd);

error_put_reg_pos: