Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7dac745b authored by Tejun Heo's avatar Tejun Heo Committed by Jeff Garzik
Browse files

sata_nv: give up hardreset on nf2 



Kernel bz#12176 reports that nf2 hardreset simply doesn't work.  Give
up.  Argh...

Signed-off-by: default avatarTejun Heo <tj@kernel.org>
Cc: Robert Hancock <hancockr@shaw.ca>
Reported-by: default avatarSaro <saro_v@hotmail.it>
Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
parent d1b3525b

drivers/ata/sata_nv.c

+8 −6
Original line number Diff line number Diff line
@@ -421,19 +421,21 @@ static struct ata_port_operations nv_generic_ops = { 
	.hardreset		= ATA_OP_NULL,

};



/* OSDL bz3352 reports that nf2/3 controllers can't determine device

 * signature reliably.  Also, the following thread reports detection

 * failure on cold boot with the standard debouncing timing.

/* nf2 is ripe with hardreset related problems.

 *

 * kernel bz#3352 reports nf2/3 controllers can't determine device

 * signature reliably.  The following thread reports detection failure

 * on cold boot with the standard debouncing timing.

 *

 * http://thread.gmane.org/gmane.linux.ide/34098

 *

 * Debounce with hotplug timing and request follow-up SRST.

 * And bz#12176 reports that hardreset simply doesn't work on nf2.

 * Give up on it and just don't do hardreset.

 */

static struct ata_port_operations nv_nf2_ops = {

	.inherits		= &nv_common_ops,

	.inherits		= &nv_generic_ops,

	.freeze			= nv_nf2_freeze,

	.thaw			= nv_nf2_thaw,

	.hardreset		= nv_noclassify_hardreset,

};



/* For initial probing after boot and hot plugging, hardreset mostly