Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7c75be09 authored by Johan Hovold's avatar Johan Hovold Committed by Gerrit - the friendly Code Review server
Browse files

USB: serial: console: fix use-after-free after failed setup 

Make sure to reset the USB-console port pointer when console setup fails
in order to avoid having the struct usb_serial be prematurely freed by
the console code when the device is later disconnected.

Change-Id: I4521740cfd288e745474d0de819a8304b72a2159
Git-commit: 299d7572e46f98534033a9e65973f13ad1ce9047
Git-repo: https://github.com/torvalds/linux/commit


Fixes: 73e487fd ("[PATCH] USB console: fix disconnection issues")
Cc: stable <stable@vger.kernel.org>	# 2.6.18
Acked-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarSrinivasa Rao Kuppala <srkupp@codeaurora.org>
parent 830bf7cc

drivers/usb/serial/console.c

+1 −0
Original line number Diff line number Diff line
@@ -187,6 +187,7 @@ static int usb_console_setup(struct console *co, char *options) 
	tty_kref_put(tty);

 reset_open_count:

	port->port.count = 0;

	info->port = NULL;

	usb_autopm_put_interface(serial->interface);

 error_get_interface:

	usb_serial_put(serial);