Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7c4845fd authored by Krishna Srinivas's avatar Krishna Srinivas Committed by Gerrit - the friendly Code Review server
Browse files

msm: mdss: Fix memleak in panel_debug_reg_write 



Free panel buffer or register buffer if either
allocation fails.

Change-Id: I600c646a0c23b654392d8e00a829bfd88b71c38c
Signed-off-by: default avatarKrishna Srinivas <krisrini@codeaurora.org>
parent d71271a8

drivers/video/msm/mdss/mdss_debug.c

+4 −3
Original line number Diff line number Diff line
@@ -214,6 +214,7 @@ static ssize_t panel_debug_base_reg_read(struct file *file, 
	struct mdss_panel_data *panel_data = ctl->panel_data;

	struct mdss_dsi_ctrl_pdata *ctrl_pdata = container_of(panel_data,

					struct mdss_dsi_ctrl_pdata, panel_data);

	int rc = -EFAULT;



	if (!dbg)

		return -ENODEV;
@@ -232,7 +233,8 @@ static ssize_t panel_debug_base_reg_read(struct file *file, 


	if (!rx_buf || !panel_reg_buf) {

		pr_err("not enough memory to hold panel reg dump\n");

		return -ENOMEM;

		rc = -ENOMEM;

		goto read_reg_fail;

	}



	if (mdata->debug_inf.debug_enable_clock)
@@ -267,8 +269,7 @@ static ssize_t panel_debug_base_reg_read(struct file *file, 
read_reg_fail:

	kfree(rx_buf);

	kfree(panel_reg_buf);

	return -EFAULT;



	return rc;

}



static const struct file_operations panel_off_fops = {