Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7c1e076e authored by Kangjie Lu's avatar Kangjie Lu Committed by Greg Kroah-Hartman
Browse files

ALSA: timer: Fix leak in events via snd_timer_user_tinterrupt 



commit e4ec8cc8039a7063e24204299b462bd1383184a5 upstream.

The stack object “r1” has a total size of 32 bytes. Its field
“event” and “val” both contain 4 bytes padding. These 8 bytes
padding bytes are sent to user without being initialized.

Signed-off-by: default avatarKangjie Lu <kjlu@gatech.edu>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarAmit Pundir <amit.pundir@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent bbb79774

sound/core/timer.c

+1 −0
Original line number Original line Diff line number Diff line
@@ -1295,6 +1295,7 @@ static void snd_timer_user_tinterrupt(struct snd_timer_instance *timeri, 
	}

	}

	if ((tu->filter & (1 << SNDRV_TIMER_EVENT_RESOLUTION)) &&

	if ((tu->filter & (1 << SNDRV_TIMER_EVENT_RESOLUTION)) &&

	    tu->last_resolution != resolution) {

	    tu->last_resolution != resolution) {

		memset(&r1, 0, sizeof(r1));

		r1.event = SNDRV_TIMER_EVENT_RESOLUTION;

		r1.event = SNDRV_TIMER_EVENT_RESOLUTION;

		r1.tstamp = tstamp;

		r1.tstamp = tstamp;

		r1.val = resolution;

		r1.val = resolution;