Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7bcfa95e authored by Oleg Nesterov's avatar Oleg Nesterov Committed by Linus Torvalds
Browse files

[PATCH] do_acct_process(): don't take tty_mutex 



No need to take the global tty_mutex, signal->tty->driver can't go away while
we are holding ->siglock.

Signed-off-by: default avatarOleg Nesterov <oleg@tv-sign.ru>
Acked-by: default avatarPeter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 91593504

kernel/acct.c

+2 −5
Original line number Diff line number Diff line
@@ -485,12 +485,9 @@ static void do_acct_process(struct file *file) 
	ac.ac_ppid = current->parent->tgid;

#endif



	mutex_lock(&tty_mutex);

	tty = get_current_tty();

	ac.ac_tty = tty ? old_encode_dev(tty_devnum(tty)) : 0;

	mutex_unlock(&tty_mutex);



	spin_lock_irq(&current->sighand->siglock);

	tty = current->signal->tty;

	ac.ac_tty = tty ? old_encode_dev(tty_devnum(tty)) : 0;

	ac.ac_utime = encode_comp_t(jiffies_to_AHZ(cputime_to_jiffies(pacct->ac_utime)));

	ac.ac_stime = encode_comp_t(jiffies_to_AHZ(cputime_to_jiffies(pacct->ac_stime)));

	ac.ac_flag = pacct->ac_flag;