Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7b789836 authored by Mathias Krause's avatar Mathias Krause Committed by David S. Miller
Browse files

xfrm_user: fix info leak in copy_to_user_policy() 



The memory reserved to dump the xfrm policy includes multiple padding
bytes added by the compiler for alignment (padding bytes in struct
xfrm_selector and struct xfrm_userpolicy_info). Add an explicit
memset(0) before filling the buffer to avoid the heap info leak.

Signed-off-by: default avatarMathias Krause <minipli@googlemail.com>
Acked-by: default avatarSteffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f778a636

net/xfrm/xfrm_user.c

+1 −0
Original line number Diff line number Diff line
@@ -1320,6 +1320,7 @@ static void copy_from_user_policy(struct xfrm_policy *xp, struct xfrm_userpolicy 


static void copy_to_user_policy(struct xfrm_policy *xp, struct xfrm_userpolicy_info *p, int dir)

{

	memset(p, 0, sizeof(*p));

	memcpy(&p->sel, &xp->selector, sizeof(p->sel));

	memcpy(&p->lft, &xp->lft, sizeof(p->lft));

	memcpy(&p->curlft, &xp->curlft, sizeof(p->curlft));