Commit 7b70bd34 authored Apr 18, 2011 by Borislav Petkov Committed by Ingo Molnar Apr 19, 2011

x86, MCE: Do not taint when handling correctable errors



Correctable errors are considered something rather normal on
modern hardware these days. Even more importantly, correctable
errors mean exactly that - they've been corrected by the
hardware - and there's no need to taint the kernel since
execution hasn't been compromised so far.

Also, drop tainting in the thermal throttling code for a similar
reason: crossing a thermal threshold does not mean corruption.

Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
Acked-by: Tony Luck <tony.luck@intel.com>
Acked-by: Nagananda Chumbalkar <Nagananda.Chumbalkar@hp.com>
Cc: Prarit Bhargava <prarit@redhat.com>
Cc: Russ Anderson <rja@sgi.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Link: http://lkml.kernel.org/r/1303135222-17118-1-git-send-email-bp@amd64.org


Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent f0e615c3

arch/x86/kernel/cpu/mcheck/mce.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -590,7 +590,6 @@ void machine_check_poll(enum mcp_flags flags, mce_banks_t *b)
		if (!(flags & MCP_DONTLOG) && !mce_dont_log_ce) {
		mce_log(&m);
		atomic_notifier_call_chain(&x86_mce_decoder_chain, 0, &m);
		add_taint(TAINT_MACHINE_CHECK);
		}

		/*

arch/x86/kernel/cpu/mcheck/therm_throt.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -187,8 +187,6 @@ static int therm_throt_process(bool new_event, int event, int level)
		this_cpu,
		level == CORE_LEVEL ? "Core" : "Package",
		state->count);

		add_taint(TAINT_MACHINE_CHECK);
		return 1;
		}
		if (old_event) {
		@@ -393,7 +391,6 @@ static void unexpected_thermal_interrupt(void)
		{
		printk(KERN_ERR "CPU%d: Unexpected LVT thermal interrupt!\n",
		smp_processor_id());
		add_taint(TAINT_MACHINE_CHECK);
		}

		static void (*smp_thermal_vector)(void) = unexpected_thermal_interrupt;