Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7ae9d71e authored by Haojian Zhuang's avatar Haojian Zhuang Committed by Linus Walleij
Browse files

pinctrl: remove mutex lock in groups show 



Mutex is locked duplicatly by pinconf_groups_show() and
pin_config_group_get(). It results dead lock. So avoid to lock mutex
in pinconf_groups_show().

Cc: stable@kernel.org
Signed-off-by: default avatarHaojian Zhuang <haojian.zhuang@gmail.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent a03690e4

drivers/pinctrl/pinconf.c

+0 −4
Original line number Diff line number Diff line
@@ -537,8 +537,6 @@ static int pinconf_groups_show(struct seq_file *s, void *what) 
	seq_puts(s, "Pin config settings per pin group\n");

	seq_puts(s, "Format: group (name): configs\n");



	mutex_lock(&pinctrl_mutex);



	while (selector < ngroups) {

		const char *gname = pctlops->get_group_name(pctldev, selector);
@@ -549,8 +547,6 @@ static int pinconf_groups_show(struct seq_file *s, void *what) 
		selector++;

	}



	mutex_unlock(&pinctrl_mutex);



	return 0;

}