Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7adccfcc authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

ASoC: nuc900: Fix a loop timeout test 




[ Upstream commit 65a12b3aafed5fc59f4ce41b22b752b1729e6701 ]

We should be finishing the loop with timeout set to zero but because
this is a post-op we finish with timeout == -1.

Fixes: 1082e270 ("ASoC: NUC900/audio: add nuc900 audio driver support")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Signed-off-by: default avatarSasha Levin <alexander.levin@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b065d8cd

sound/soc/nuc900/nuc900-ac97.c

+2 −2
Original line number Diff line number Diff line
@@ -67,7 +67,7 @@ static unsigned short nuc900_ac97_read(struct snd_ac97 *ac97, 


	/* polling the AC_R_FINISH */

	while (!(AUDIO_READ(nuc900_audio->mmio + ACTL_ACCON) & AC_R_FINISH)

								&& timeout--)

								&& --timeout)

		mdelay(1);



	if (!timeout) {
@@ -121,7 +121,7 @@ static void nuc900_ac97_write(struct snd_ac97 *ac97, unsigned short reg, 


	/* polling the AC_W_FINISH */

	while ((AUDIO_READ(nuc900_audio->mmio + ACTL_ACCON) & AC_W_FINISH)

								&& timeout--)

								&& --timeout)

		mdelay(1);



	if (!timeout)