Commit 7a400543 authored Mar 30, 2014 by Axel Lin Committed by Mark Brown Apr 14, 2014

spi: fsl-spi: Fix memory leak



mpc8xxx_spi_probe() has set master->cleanup = mpc8xxx_spi_cleanup,
however current code overrides the setting in fsl_spi_probe() and set
master->cleanup = fsl_spi_cleanup.
Thus the memory allocated for cs is not freed anywhere.
Convert to use devm_kzalloc to fix the memory leak.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mark Brown <broonie@linaro.org>

parent abcadeb2

drivers/spi/spi-fsl-spi.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -431,7 +431,7 @@ static int fsl_spi_setup(struct spi_device *spi)
		return -EINVAL;

		if (!cs) {
		cs = kzalloc(sizeof *cs, GFP_KERNEL);
		cs = devm_kzalloc(&spi->dev, sizeof(*cs), GFP_KERNEL);
		if (!cs)
		return -ENOMEM;
		spi->controller_state = cs;