Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 79cc56af authored by Thomas Renninger's avatar Thomas Renninger Committed by Dave Jones
Browse files

[CPUFREQ] powernow-k8: Only print error message once, not per core. 



This is the typical message you get if you plug in a CPU
which is newer than your BIOS. It's annoying seeing this
message for each core.

Signed-off-by: default avatarThomas Renninger <trenn@suse.de>
Signed-off-by: default avatarDave Jones <davej@redhat.com>
parent 112124ab

arch/x86/kernel/cpu/cpufreq/powernow-k8.c

+15 −6
Original line number Diff line number Diff line
@@ -794,7 +794,7 @@ static int find_psb_table(struct powernow_k8_data *data) 
	 * BIOS and Kernel Developer's Guide, which is available on

	 * www.amd.com

	 */

	printk(KERN_ERR PFX "BIOS error - no PSB or ACPI _PSS objects\n");

	printk(KERN_ERR FW_BUG PFX "No PSB or ACPI _PSS objects\n");

	return -ENODEV;

}
@@ -1218,6 +1218,7 @@ static int __cpuinit powernowk8_cpu_init(struct cpufreq_policy *pol) 
	struct powernow_k8_data *data;

	cpumask_t oldmask;

	int rc;

	static int print_once;



	if (!cpu_online(pol->cpu))

		return -ENODEV;
@@ -1240,11 +1241,19 @@ static int __cpuinit powernowk8_cpu_init(struct cpufreq_policy *pol) 
		 * an UP version, and is deprecated by AMD.

		 */

		if (num_online_cpus() != 1) {

			printk(KERN_ERR FW_BUG PFX "Your BIOS does not provide"

			       " ACPI _PSS objects in a way that Linux "

			       "understands. Please report this to the Linux "

			       "ACPI maintainers and complain to your BIOS "

			       "vendor.\n");

			/*

			 * Replace this one with print_once as soon as such a

			 * thing gets introduced

			 */

			if (!print_once) {

				WARN_ONCE(1, KERN_ERR FW_BUG PFX "Your BIOS "

					"does not provide ACPI _PSS objects "

					"in a way that Linux understands. "

					"Please report this to the Linux ACPI"

					" maintainers and complain to your "

					"BIOS vendor.\n");

				print_once++;

			}

			kfree(data);

			return -ENODEV;

		}