Commit 78d820e8 authored Jan 17, 2014 by Jacob Keller Committed by David S. Miller Jan 17, 2014

ixgbe: add braces around else condition in ixgbe_qv_lock_* calls

This patch adds braces around the ixgbe_qv_lock_* calls which previously only
had braces around the if portion. Kernel style guidelines for this require
parenthesis around all conditions if they are required around one. In addition
the comment while not illegal C syntax makes the code look wrong at a cursory
glance. This patch corrects the style and adds braces so that the full if-else
block is uniform.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Phil Schmitt <phillip.j.schmitt@intel.com>
Signed-off-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 0113e34b

drivers/net/ethernet/intel/ixgbe/ixgbe.h

+4 −2

Original line number	Diff line number	Diff line
		@@ -424,9 +424,10 @@ static inline bool ixgbe_qv_lock_napi(struct ixgbe_q_vector *q_vector)
		#ifdef BP_EXTENDED_STATS
		q_vector->tx.ring->stats.yields++;
		#endif
		} else
		} else {
		/* we don't care if someone yielded */
		q_vector->state = IXGBE_QV_STATE_NAPI;
		}
		spin_unlock_bh(&q_vector->lock);
		return rc;
		}
		@@ -458,9 +459,10 @@ static inline bool ixgbe_qv_lock_poll(struct ixgbe_q_vector *q_vector)
		#ifdef BP_EXTENDED_STATS
		q_vector->rx.ring->stats.yields++;
		#endif
		} else
		} else {
		/* preserve yield marks */
		q_vector->state \|= IXGBE_QV_STATE_POLL;
		}
		spin_unlock_bh(&q_vector->lock);
		return rc;
		}