Commit 77edeac4 authored Apr 11, 2018 by Mauro Carvalho Chehab Committed by Greg Kroah-Hartman Jul 03, 2018

media: v4l2-compat-ioctl32: prevent go past max size



commit ea72fbf588ac9c017224dcdaa2019ff52ca56fee upstream.

As warned by smatch:
	drivers/media/v4l2-core/v4l2-compat-ioctl32.c:879 put_v4l2_ext_controls32() warn: check for integer overflow 'count'

The access_ok() logic should check for too big arrays too.

Cc: stable@vger.kernel.org
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 8d2e0fa5

drivers/media/v4l2-core/v4l2-compat-ioctl32.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -856,7 +856,7 @@ static int put_v4l2_ext_controls32(struct file *file,
		get_user(kcontrols, &kp->controls))
		return -EFAULT;

		if (!count)
		if (!count \|\| count > (U32_MAX/sizeof(*ucontrols)))
		return 0;
		if (get_user(p, &up->controls))
		return -EFAULT;