Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 77bc6bed authored by YOSHIFUJI Hideaki / 吉藤英明's avatar YOSHIFUJI Hideaki / 吉藤英明 Committed by David S. Miller
Browse files

isdnloop: Validate NUL-terminated strings from user. 



Return -EINVAL unless all of user-given strings are correctly
NUL-terminated.

Signed-off-by: default avatarYOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 79eb9d28

drivers/isdn/isdnloop/isdnloop.c

+6 −0
Original line number Diff line number Diff line
@@ -1070,6 +1070,12 @@ isdnloop_start(isdnloop_card *card, isdnloop_sdef *sdefp) 
		return -EBUSY;

	if (copy_from_user((char *) &sdef, (char *) sdefp, sizeof(sdef)))

		return -EFAULT;



	for (i = 0; i < 3; i++) {

		if (!memchr(sdef.num[i], 0, sizeof(sdef.num[i])))

			return -EINVAL;

	}



	spin_lock_irqsave(&card->isdnloop_lock, flags);

	switch (sdef.ptype) {

	case ISDN_PTYPE_EURO: