Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7738dd9e authored by David Rientjes's avatar David Rientjes Committed by Pekka Enberg
Browse files

slub: remove impossible condition 



`s' cannot be NULL if kmalloc_caches is not NULL.

This conditional would trigger a NULL pointer on `s', anyway, since it is
immediately derefernced if true.

Acked-by: default avatarChristoph Lameter <cl@linux-foundation.org>
Signed-off-by: default avatarDavid Rientjes <rientjes@google.com>
Signed-off-by: default avatarPekka Enberg <penberg@cs.helsinki.fi>
parent 84e554e6

mm/slub.c

+1 −1
Original line number Diff line number Diff line
@@ -2641,7 +2641,7 @@ static noinline struct kmem_cache *dma_kmalloc_cache(int index, gfp_t flags) 
	if (slab_state >= SYSFS)

		slabflags |= __SYSFS_ADD_DEFERRED;



	if (!s || !text || !kmem_cache_open(s, flags, text,

	if (!text || !kmem_cache_open(s, flags, text,

			realsize, ARCH_KMALLOC_MINALIGN, slabflags, NULL)) {

		s->size = 0;

		kfree(text);