Commit 76c317d6 authored Jul 19, 2009 by Julia Lawall Committed by Jiri Kosina Jul 20, 2009

HID: Move dereferences below a NULL test

If the NULL test is necessary, then the dereferences should be moved below
the NULL test.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/

)

// <smpl>
@@
type T;
expression E,E1;
identifier i,fld;
statement S;
@@

- T i = E->fld;
+ T i;
  ... when != E=E1
      when != i
  if (E == NULL||...) S
+ i = E->fld;
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent 4859484b

drivers/hid/hid-core.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -1075,14 +1075,16 @@ EXPORT_SYMBOL_GPL(hid_report_raw_event);
		*/
		int hid_input_report(struct hid_device hid, int type, u8 data, int size, int interrupt)
		{
		struct hid_report_enum *report_enum = hid->report_enum + type;
		struct hid_driver *hdrv = hid->driver;
		struct hid_report_enum *report_enum;
		struct hid_driver *hdrv;
		struct hid_report *report;
		unsigned int i;
		int ret;

		if (!hid \|\| !hid->driver)
		return -ENODEV;
		report_enum = hid->report_enum + type;
		hdrv = hid->driver;

		if (!size) {
		dbg_hid("empty report\n");