Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7591782b authored by Martin Peres's avatar Martin Peres Committed by Ben Skeggs
Browse files

drm/nouveau/therm: do not make assumptions on temperature 



In nouveau_therm_sensor_event, temperature is stored as an uint8_t
even though the original interface returns an int.

This change should make it more obvious when the sensor is either
very-ill-calibrated or when we selected the wrong sensor style
on the nv40 family.

Signed-off-by: default avatarMartin Peres <martin.peres@labri.fr>
Signed-off-by: default avatarBen Skeggs <bskeggs@redhat.com>
parent eea4eb14

drivers/gpu/drm/nouveau/core/subdev/therm/temp.c

+3 −3
Original line number Diff line number Diff line
@@ -106,16 +106,16 @@ void nouveau_therm_sensor_event(struct nouveau_therm *therm, 
	const char *thresolds[] = {

		"fanboost", "downclock", "critical", "shutdown"

	};

	uint8_t temperature = therm->temp_get(therm);

	int temperature = therm->temp_get(therm);



	if (thrs < 0 || thrs > 3)

		return;



	if (dir == NOUVEAU_THERM_THRS_FALLING)

		nv_info(therm, "temperature (%u C) went below the '%s' threshold\n",

		nv_info(therm, "temperature (%i C) went below the '%s' threshold\n",

			temperature, thresolds[thrs]);

	else

		nv_info(therm, "temperature (%u C) hit the '%s' threshold\n",

		nv_info(therm, "temperature (%i C) hit the '%s' threshold\n",

			temperature, thresolds[thrs]);



	active = (dir == NOUVEAU_THERM_THRS_RISING);