Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7568ba6c authored by Kees Cook's avatar Kees Cook Committed by Greg Kroah-Hartman
Browse files

video: uvesafb: Fix integer overflow in allocation 



commit 9f645bcc566a1e9f921bdae7528a01ced5bc3713 upstream.

cmap->len can get close to INT_MAX/2, allowing for an integer overflow in
allocation. This uses kmalloc_array() instead to catch the condition.

Reported-by: default avatarDr Silvio Cesare of InfoSect <silvio.cesare@gmail.com>
Fixes: 8bdb3a2d ("uvesafb: the driver core")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarKees Cook <keescook@chromium.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 626fb932

drivers/video/fbdev/uvesafb.c

+2 −1
Original line number Diff line number Diff line
@@ -1059,7 +1059,8 @@ static int uvesafb_setcmap(struct fb_cmap *cmap, struct fb_info *info) 
		    info->cmap.len || cmap->start < info->cmap.start)

			return -EINVAL;



		entries = kmalloc(sizeof(*entries) * cmap->len, GFP_KERNEL);

		entries = kmalloc_array(cmap->len, sizeof(*entries),

					GFP_KERNEL);

		if (!entries)

			return -ENOMEM;