Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 73d7c119 authored by Guenter Roeck's avatar Guenter Roeck
Browse files

hwmon: (twl4030-madc-hwmon) Initialize uninitialized structure elements 



twl4030_madc_conversion uses do_avg and type structure elements of
twl4030_madc_request. Initialize structure to avoid random operation.

Fix for: Coverity CID 200794 Uninitialized scalar variable.

Cc: Keerthy <j-keerthy@ti.com>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Acked-by: default avatarJean Delvare <khali@linux-fr.org>
Acked-by: default avatarKeerthy <j-keerthy@ti.com>
parent 55d512e2

drivers/hwmon/twl4030-madc-hwmon.c

+5 −4
Original line number Diff line number Diff line
@@ -44,12 +44,13 @@ static ssize_t madc_read(struct device *dev, 
			 struct device_attribute *devattr, char *buf)

{

	struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);

	struct twl4030_madc_request req;

	struct twl4030_madc_request req = {

		.channels = 1 << attr->index,

		.method = TWL4030_MADC_SW2,

		.type = TWL4030_MADC_WAIT,

	};

	long val;



	req.channels = (1 << attr->index);

	req.method = TWL4030_MADC_SW2;

	req.func_cb = NULL;

	val = twl4030_madc_conversion(&req);

	if (val < 0)

		return val;