Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7364e445 authored by Alexey Khoroshilov's avatar Alexey Khoroshilov Committed by David S. Miller
Browse files

net/core: Fix potential memory leak in dev_set_alias() 



Do not leak memory by updating pointer with potentially NULL realloc return value.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: default avatarAlexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 47dffc75

net/core/dev.c

+5 −2
Original line number Diff line number Diff line
@@ -1055,6 +1055,8 @@ rollback: 
 */

int dev_set_alias(struct net_device *dev, const char *alias, size_t len)

{

	char *new_ifalias;



	ASSERT_RTNL();



	if (len >= IFALIASZ)
@@ -1068,9 +1070,10 @@ int dev_set_alias(struct net_device *dev, const char *alias, size_t len) 
		return 0;

	}



	dev->ifalias = krealloc(dev->ifalias, len + 1, GFP_KERNEL);

	if (!dev->ifalias)

	new_ifalias = krealloc(dev->ifalias, len + 1, GFP_KERNEL);

	if (!new_ifalias)

		return -ENOMEM;

	dev->ifalias = new_ifalias;



	strlcpy(dev->ifalias, alias, len+1);

	return len;