Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 72db395f authored by Rusty Russell's avatar Rusty Russell
Browse files

module_param: check that bool parameters really are bool. 



module_param(bool) used to counter-intuitively take an int.  In
fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
trick.

This tightens the check (you'll get a warning about incompatible
return type) but still allows it.  Next kernel version, we'll remove
it.

Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
parent a6e02554

include/linux/moduleparam.h

+2 −8
Original line number Diff line number Diff line
@@ -350,17 +350,11 @@ extern int param_set_charp(const char *val, const struct kernel_param *kp); 
extern int param_get_charp(char *buffer, const struct kernel_param *kp);

#define param_check_charp(name, p) __param_check(name, p, char *)



/* For historical reasons "bool" parameters can be (unsigned) "int". */

/* We used to allow int as well as bool.  We're taking that away! */

extern struct kernel_param_ops param_ops_bool;

extern int param_set_bool(const char *val, const struct kernel_param *kp);

extern int param_get_bool(char *buffer, const struct kernel_param *kp);

#define param_check_bool(name, p)					\

	static inline void __check_##name(void)				\

	{								\

		BUILD_BUG_ON(!__same_type((p), bool *) &&		\

			     !__same_type((p), unsigned int *) &&	\

			     !__same_type((p), int *));			\

	}

#define param_check_bool(name, p) __param_check(name, p, bool)



extern struct kernel_param_ops param_ops_invbool;

extern int param_set_invbool(const char *val, const struct kernel_param *kp);