Commit 72bb6f9b authored Jul 10, 2012 by Kevin Hilman

ARM: OMAP: omap_device: don't attempt late suspend if no driver bound



Currently, the omap_device PM domain layer uses the late suspend and
early resume callbacks to ensure devices are in their low power
states.

However, this is attempted even in cases where a driver probe has
failed.  If a driver's ->probe() method fails, the driver is likely in
a state where it is not expecting its runtime PM callbacks to be
called, yet currently the omap_device PM domain code attempts to call
the drivers callbacks.

To fix, use the omap_device driver_status field to check whether a
driver is bound to the omap_device before attempting to trigger driver
callbacks.

Reviewed-by: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Kevin Hilman <khilman@ti.com>

parent e753345b

arch/arm/plat-omap/omap_device.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -756,6 +756,10 @@ static int _od_suspend_noirq(struct device *dev)
		struct omap_device *od = to_omap_device(pdev);
		int ret;

		/* Don't attempt late suspend on a driver that is not bound */
		if (od->_driver_status != BUS_NOTIFY_BOUND_DRIVER)
		return 0;

		ret = pm_generic_suspend_noirq(dev);

		if (!ret && !pm_runtime_status_suspended(dev)) {