Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 72749a27 authored by Dan Carpenter's avatar Dan Carpenter Committed by Boaz Harrosh
Browse files

exofs: Cap on the memcpy() size 



This data comes from the device, so probably it's fairly trustworthy but
it makes the static checkers happy if we check it.

[Boaz]
  the system_id_len is zero, if not present, or always OSD_SYSTEMID_LEN.
  So always copy OSD_SYSTEMID_LEN bytes.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarBoaz Harrosh <bharrosh@panasas.com>
parent 3e57638b

fs/exofs/super.c

+2 −1
Original line number Diff line number Diff line
@@ -529,7 +529,8 @@ static int exofs_devs_2_odi(struct exofs_dt_device_info *dt_dev, 
			     struct osd_dev_info *odi)

{

	odi->systemid_len = le32_to_cpu(dt_dev->systemid_len);

	memcpy(odi->systemid, dt_dev->systemid, odi->systemid_len);

	if (likely(odi->systemid_len))

		memcpy(odi->systemid, dt_dev->systemid, OSD_SYSTEMID_LEN);



	odi->osdname_len = le32_to_cpu(dt_dev->osdname_len);

	odi->osdname = dt_dev->osdname;