Commit 71c879eb authored Mar 30, 2016 by Daniel Vetter Committed by Sasha Levin Jul 12, 2016

drm/udl: Use unlocked gem unreferencing



[ Upstream commit 72b9ff0612ad8fc969b910cd00ac16b57a1a9ba4 ]

For drm_gem_object_unreference callers are required to hold
dev->struct_mutex, which these paths don't. Enforcing this requirement
has become a bit more strict with

commit ef4c6270bf2867e2f8032e9614d1a8cfc6c71663
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Thu Oct 15 09:36:25 2015 +0200

    drm/gem: Check locking in drm_gem_object_unreference

Cc: stable@vger.kernel.org
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>

parent 2539420b

drivers/gpu/drm/udl/udl_fb.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -546,7 +546,7 @@ static int udlfb_create(struct drm_fb_helper *helper,

		return ret;
		out_gfree:
		drm_gem_object_unreference(&ufbdev->ufb.obj->base);
		drm_gem_object_unreference_unlocked(&ufbdev->ufb.obj->base);
		out:
		return ret;
		}

drivers/gpu/drm/udl/udl_gem.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -51,7 +51,7 @@ udl_gem_create(struct drm_file *file,
		return ret;
		}

		drm_gem_object_unreference(&obj->base);
		drm_gem_object_unreference_unlocked(&obj->base);
		*handle_p = handle;
		return 0;
		}