Commit 70a15e1a authored Aug 25, 2014 by Ulf Hansson

mmc: tmio_mmc: Fixup system PM suspend lock-up



At system PM suspend, the tmio core accessed the internal registers of
the controller without first moving the device into active state. This
caused a lock-up in system PM suspend phase.

The reason for the register access were masking of IRQs. Since that is
managed via the runtime PM suspend path, let's just re-use that path
for system PM suspend.

In other words force the device into runtime PM suspend state at system
PM suspend and restore it to active state at system PM resume.

Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>

parent 753a688c

drivers/mmc/host/tmio_mmc.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -30,7 +30,7 @@ static int tmio_mmc_suspend(struct device *dev)
		const struct mfd_cell *cell = mfd_get_cell(pdev);
		int ret;

		ret = tmio_mmc_host_suspend(dev);
		ret = pm_runtime_force_suspend(dev);

		/* Tell MFD core it can disable us now.*/
		if (!ret && cell->disable)
		@@ -50,7 +50,7 @@ static int tmio_mmc_resume(struct device *dev)
		ret = cell->resume(pdev);

		if (!ret)
		ret = tmio_mmc_host_resume(dev);
		ret = pm_runtime_force_resume(dev);

		return ret;
		}