Commit 70142a9d authored Feb 11, 2012 by Ben Hutchings Committed by Greg Kroah-Hartman Feb 13, 2012

x86/cpu: Fix overrun check in arch_print_cpu_modalias()



snprintf() does not return a negative value when truncating.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Acked-by: Thomas Renninger <trenn@suse.de>
Acked-by: H. Peter Anvin <hpa@zytor.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent da5a70f3

arch/x86/kernel/cpu/match.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -67,7 +67,7 @@ ssize_t arch_print_cpu_modalias(struct device *dev,
		for (i = 0; i < NCAPINTS*32; i++) {
		if (boot_cpu_has(i)) {
		n = snprintf(buf, size, ",%04X", i);
		if (n < 0) {
		if (n >= size) {
		WARN(1, "x86 features overflow page\n");
		break;
		}