Commit 700ff4f0 authored Jan 10, 2013 by Dan Carpenter Committed by Chris Mason Dec 12, 2013

Btrfs: fix access_ok() check in btrfs_ioctl_send()



The closing parenthesis is in the wrong place.  We want to check
"sizeof(*arg->clone_sources) * arg->clone_sources_count" instead of
"sizeof(*arg->clone_sources * arg->clone_sources_count)".

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Jie Liu <jeff.liu@oracle.com>
Signed-off-by: Chris Mason <clm@fb.com>
cc: stable@vger.kernel.org

parent 467bb1d2

fs/btrfs/send.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -4723,8 +4723,8 @@ long btrfs_ioctl_send(struct file mnt_file, void __user arg_)
		}

		if (!access_ok(VERIFY_READ, arg->clone_sources,
		sizeof(arg->clone_sources
		arg->clone_sources_count))) {
		sizeof(arg->clone_sources)
		arg->clone_sources_count)) {
		ret = -EFAULT;
		goto out;
		}