Commit 6fbc7692 authored Sep 26, 2011 by Mark Salyzyn Committed by James Bottomley Oct 02, 2011

[SCSI] pm8001: missing break statements

Code Inspection: found two missing break directives. First one will
result in not retrying an a task that report
IO_OPEN_CNX_ERROR_HW_RESOURCE_BUSY, the second will result in cosmetic
debug printk conflicting statement stutter. Because checkpatch.pl came
up with a warning regarding unnecessary space before a newline on one of
the fragments associated with the diff context, I took the liberty of
fixing all the cases of this issue in the pair of files touched by this
defect. These cosmetic changes hide the break changes :-(

To help focus, break changes are in pm8001_hwi.c fragment line 1649 for
the IO_OPEN_CNX_ERROR_HW_RESOURCE_BUSY case statement and pm8001_sas.c
line 1000 deals with the conflicting debug print stutter.

Signed-off-by: Mark Salyzyn <mark_salyzyn@us.xyratex.com>
Acked-by: Jack Wang <jack_wang@usish.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>

parent b90b378a

drivers/scsi/pm8001/pm8001_hwi.c

+37 −36

Original line number	Diff line number	Diff line
		@@ -1649,6 +1649,7 @@ mpi_ssp_completion(struct pm8001_hba_info pm8001_ha , void piomb)
		ts->resp = SAS_TASK_COMPLETE;
		ts->stat = SAS_OPEN_REJECT;
		ts->open_rej_reason = SAS_OREJ_RSVD_RETRY;
		break;
		default:
		PM8001_IO_DBG(pm8001_ha,
		pm8001_printk("Unknown status 0x%x\n", status));

drivers/scsi/pm8001/pm8001_sas.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -959,6 +959,7 @@ int pm8001_query_task(struct sas_task *task)
		case TMF_RESP_FUNC_SUCC:
		PM8001_EH_DBG(pm8001_ha,
		pm8001_printk("The task is still in Lun\n"));
		break;
		/* The task is not in Lun or failed, reset the phy */
		case TMF_RESP_FUNC_FAILED:
		case TMF_RESP_FUNC_COMPLETE: