Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6f3e0e8a authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by Greg Kroah-Hartman
Browse files

usb: cdc-wdm: Fix a sleep-in-atomic-context bug in service_outstanding_interrupt() 



commit 6e22e3af7bb3a7b9dc53cb4687659f6e63fca427 upstream.

wdm_in_callback() is a completion handler function for the USB driver.
So it should not sleep. But it calls service_outstanding_interrupt(),
which calls usb_submit_urb() with GFP_KERNEL.

To fix this bug, GFP_KERNEL is replaced with GFP_ATOMIC.

This bug is found by my static analysis tool DSAC.

Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a89c7b5a

drivers/usb/class/cdc-wdm.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -452,7 +452,7 @@ static int clear_wdm_read_flag(struct wdm_device *desc) 




	set_bit(WDM_RESPONDING, &desc->flags);

	set_bit(WDM_RESPONDING, &desc->flags);

	spin_unlock_irq(&desc->iuspin);

	spin_unlock_irq(&desc->iuspin);

	rv = usb_submit_urb(desc->response, GFP_KERNEL);

	rv = usb_submit_urb(desc->response, GFP_ATOMIC);

	spin_lock_irq(&desc->iuspin);

	spin_lock_irq(&desc->iuspin);

	if (rv) {

	if (rv) {

		dev_err(&desc->intf->dev,

		dev_err(&desc->intf->dev,