Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6f1f56ea authored by Ben Greear's avatar Ben Greear Committed by Kalle Valo
Browse files

ath10k: Fix un-initialized debug objects. 



If the 'ar' registration fails early, the debug
objects were not initialized, and trouble ensued when
the object was later destroyed and the un-initialized
objects were accessed.

Per Kalle's suggestion, move the debug_destroy to the
core_unregister method.

Signed-off-by: default avatarBen Greear <greearb@candelatech.com>
Signed-off-by: default avatarKalle Valo <kvalo@qca.qualcomm.com>
parent 12eb0879

drivers/net/wireless/ath/ath10k/core.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -738,8 +738,6 @@ EXPORT_SYMBOL(ath10k_core_create); 




void ath10k_core_destroy(struct ath10k *ar)

void ath10k_core_destroy(struct ath10k *ar)

{

{

	ath10k_debug_destroy(ar);



	flush_workqueue(ar->workqueue);

	flush_workqueue(ar->workqueue);

	destroy_workqueue(ar->workqueue);

	destroy_workqueue(ar->workqueue);
@@ -986,6 +984,8 @@ void ath10k_core_unregister(struct ath10k *ar) 
	ath10k_mac_unregister(ar);

	ath10k_mac_unregister(ar);





	ath10k_core_free_firmware_files(ar);

	ath10k_core_free_firmware_files(ar);



	ath10k_debug_destroy(ar);

}

}

EXPORT_SYMBOL(ath10k_core_unregister);

EXPORT_SYMBOL(ath10k_core_unregister);