Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6f08b72c authored by Kirill Smelkov's avatar Kirill Smelkov Committed by Linus Torvalds
Browse files

[PATCH] serial moxa: fix wrong BUG 



There is a wrong BUG in mxser_close.

The BUG is triggered when tty->driver_data == NULL, But in fact this is not
a bug, because tty->driver->close is called even when tty->driver->open
fails.

LDD3 tells us to do nothing in such cases.

Signed-off-by: default avatarKirill Smelkov <kirr@mns.spb.ru>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 64698b69

drivers/char/mxser.c

+4 −1
Original line number Diff line number Diff line
@@ -917,6 +917,9 @@ static int mxser_open(struct tty_struct *tty, struct file *filp) 
	struct mxser_struct *info;

	int retval, line;



	/* initialize driver_data in case something fails */

	tty->driver_data = NULL;



	line = tty->index;

	if (line == MXSER_PORTS)

		return 0;
@@ -979,7 +982,7 @@ static void mxser_close(struct tty_struct *tty, struct file *filp) 
	if (tty->index == MXSER_PORTS)

		return;

	if (!info)

		BUG();

		return;



	spin_lock_irqsave(&info->slock, flags);