Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6eebf2de authored by Wei Yongjun's avatar Wei Yongjun Committed by David Brown
Browse files

ARM: msm: dma: use list_move_tail instead of list_del/list_add_tail 

Using list_move_tail() instead of list_del() + list_add_tail().

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/

)

Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: default avatarDavid Brown <davidb@codeaurora.org>
parent 3b5909de

arch/arm/mach-msm/dma.c

+1 −2
Original line number Diff line number Diff line
@@ -223,8 +223,7 @@ static irqreturn_t msm_datamover_irq_handler(int irq, void *dev_id) 
			PRINT_FLOW("msm_datamover_irq_handler id %d, status %x\n", id, ch_status);

			if ((ch_status & DMOV_STATUS_CMD_PTR_RDY) && !list_empty(&ready_commands[id])) {

				cmd = list_entry(ready_commands[id].next, typeof(*cmd), list);

				list_del(&cmd->list);

				list_add_tail(&cmd->list, &active_commands[id]);

				list_move_tail(&cmd->list, &active_commands[id]);

				if (cmd->execute_func)

					cmd->execute_func(cmd);

				PRINT_FLOW("msm_datamover_irq_handler id %d, start command\n", id);