Commit 6ee49a20 authored Oct 02, 2014 by Eric Sandeen Committed by Dave Chinner Oct 02, 2014

xfs: don't send null bp to xfs_trans_brelse()



In this case, if bp is NULL, error is set, and we send a
NULL bp to xfs_trans_brelse, which will try to dereference it.

Test whether we actually have a buffer before we try to
free it.

Coverity spotted this.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>

parent ce57bcf6

fs/xfs/libxfs/xfs_da_btree.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -2563,6 +2563,7 @@ xfs_da_get_buf(
		mapp, nmap, 0);
		error = bp ? bp->b_error : -EIO;
		if (error) {
		if (bp)
		xfs_trans_brelse(trans, bp);
		goto out_free;
		}